Feedbacks - Scribble v2

Yedhin Kizhakkethara
Yedhin Kizhakkethara
Last updated 
Follow the same logistics as general feedbacks when fixing changes mentioned from this doc.

Start by creating a new task in https://bigbinary-orientation.neetoplanner.com/ with the title "Scribble V2 - reviews".

This time be much more vigilant while making the fixes. I should not be forced to point out to you that you have missed out on making either the general feedbacks or these v2 feedbacks when you resubmit for review!

Stating the obvious:
1) Ensure overall test coverage is atleast 97%.
2) Ensure test coverage of all models, controllers, workers and services are 100%
3) Put up a screenshot showing all these coverages when you resubmit app for review

November 7th:
  • Don't hardcode these numbers. If you move this to a constant within the closest scope, that's within the model itself, then you can utilise that constant while writing the test case rather than again hardcoding in the test case too. The idea is to ensure that we only need to change this value at one place and everywhere else, inclusive of tests, the change is reflected:
    image.png 36.2 KB View full-size Download
  • Don't use the memoized instance variable. Rather use the memoized method itself. Using the memoized variable, makes the code more shabby since we will be having an `_` everywhere:
image.png 45.8 KB View full-size Download
  • Ensure that you handle the case where the category of the article to be restored in currently deleted in the site/organization, and thus point out about the same to the consumer.